#4777: Improving Datatable SelectionChanged event

[melloware]

Fix #4777: Improving Datatable SelectionChanged event

@ulasturann @mertsincan this is what I have so far using Discriminated Unions https://www.typescriptlang.org/docs/handbook/2/narrowing.html#discriminated-unions

This seems to be the TypeScript recommended way and now if you have this...

    const [selectedProduct, setSelectedProduct] = useState<Product>({});
    const [selectedProducts, setSelectedProducts] = useState<Product[]>([]);
    const [selectedCells, setSelectedCells] = useState<DataTableCellSelection<Product[]>>();

In the selection event by checking the type it now knows the correct single, multiple, or cell type event,

<DataTable
                    value={products}
                    selectionMode="single"
                    selection={selectedProduct}
                    onSelectionChange={(e) => {
                        switch (e.type) {
                            case 'single':
                            case 'radio':
                                setSelectedProduct(e.value);
                                break;
                            case 'cell':
                                setSelectedCells(e.value);
                                break;
                            case 'multiple':
                            case 'checkbox':
                            case 'all':
                                setSelectedProducts(e.value);
                                break;
                        }
                    }}
                    dataKey="id"
                    metaKeySelection={metaKey}
                    tableStyle={{ minWidth: '50rem' }}
                >

Its not exactly what the user wants but this is a much better TypeScript way of having multiple possible outcomes.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
primereact	⬜️ Ignored (Inspect)	Visit Preview		Aug 15, 2023 8:49pm

[bu3alwa]

This looks good to me as well. Glad to see this change.

[melloware]

@bu3alwa Thanks for reviewing!

[melloware]

Better PR: #4792

Closing this one