Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3139 : After resizing and reordering column takes the size of the column it is displacing #4410

Merged
merged 14 commits into from
Aug 11, 2023
Merged

Fix #3139 : After resizing and reordering column takes the size of the column it is displacing #4410

merged 14 commits into from
Aug 11, 2023

Conversation

shuklabhisekh
Copy link
Contributor

@shuklabhisekh shuklabhisekh commented May 16, 2023 •
edited by melloware
Loading

Issues

Fix #3139 - After resizing and reordering column takes the size of the column it is displacing .

@vercel
Copy link

vercel bot commented May 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Aug 11, 2023 4:00pm

@melloware melloware requested a review from mertsincan May 16, 2023 20:12
@melloware melloware added the Status: Pending Review Issue or pull request is being reviewed by Core Team label May 16, 2023
@shuklabhisekh shuklabhisekh mentioned this pull request May 16, 2023
Closed
@shuklabhisekh
Copy link
Contributor Author

Hey, @mertsincan, could you please review this Pull Request and please let me know if you've any feedback for this Pull Request?

melloware
melloware requested changes May 22, 2023
View reviewed changes
components/lib/datatable/DataTable.js Outdated Show resolved Hide resolved
melloware
melloware requested changes May 22, 2023
View reviewed changes
components/lib/datatable/DataTable.js Outdated Show resolved Hide resolved
@shuklabhisekh shuklabhisekh requested a review from melloware May 22, 2023 18:48
@shuklabhisekh shuklabhisekh requested a review from melloware May 22, 2023 19:12
@shuklabhisekh
Copy link
Contributor Author

Hey @melloware, Thank you for approving this PR. Requesting you to please merge it also so that the bug can be fixed.

@melloware
Copy link
Member

This now is looking so much better and cleaner! I assigned to PrimeTek to review.

@melloware melloware requested a review from habubey May 22, 2023 19:15
@shuklabhisekh
Copy link
Contributor Author

Hey @habubey, could you please review this PR and let me know if you have any feedback for me

@habubey
Copy link
Contributor

habubey commented May 24, 2023

Hey @habubey, could you please review this PR and let me know if you have any feedback for me

We will check and get back to you, We should ensure and test that the PR does not cause any issues or disrupt elsewhere in this component, as you know, the DataTable is a complex component.

@shuklabhisekh
Copy link
Contributor Author

Hey @melloware, any update for this PR ?

@melloware
Copy link
Member

@shuklabhisekh PrimeTek is reviewing it. Trust me it will eventually get reviewed!

Also want to investigate this issue: #4471 ???

@melloware
Copy link
Member

@habubey multiple people on Discord also complaining about this issue it would be great if you could test and verify it?

@shuklabhisekh shuklabhisekh mentioned this pull request Jul 6, 2023
Closed
@shuklabhisekh shuklabhisekh requested a review from melloware July 27, 2023 07:31
@shuklabhisekh
Copy link
Contributor Author

Hey @melloware, @mertsincan, @habubey could you please provide me with an update on the status of this pull request? I would appreciate any information you can share. Thank you!

@melloware
Copy link
Member

I will test this tomorrow.

@melloware melloware assigned melloware and unassigned mertsincan and habubey Aug 10, 2023
@melloware melloware added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Aug 11, 2023
@melloware melloware merged commit e91ae5b into primefaces:master Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware approved these changes

@mertsincan mertsincan Awaiting requested review from mertsincan

@habubey habubey Awaiting requested review from habubey

Assignees

@melloware melloware

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Column width not change after reorder in datatable
4 participants
@shuklabhisekh @melloware @habubey @mertsincan