Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4301: Carousel never controlled while in autoplay #4303

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

melloware
Copy link
Member

@melloware melloware commented Apr 28, 2023

Fix #4301: Carousel never controlled while in autoplay

Basically it was assuming if you were using onPage that you were using it in controlled Mode where you set the props.page yourself but in AutoPlay mode that makes no sense

@vercel
Copy link

vercel bot commented Apr 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Apr 28, 2023 11:55am

@melloware melloware added the Core Team Issue or pull request has been *opened* by a member of Core Team label Apr 28, 2023
@melloware melloware merged commit 314d903 into primefaces:master Apr 28, 2023
@melloware melloware deleted the PR4301 branch April 28, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel: onPageChange and autoplayInterval does not work together
1 participant