Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add panel footer to dropdown component #4027

Merged
merged 4 commits into from
May 9, 2023

Conversation

EmirBoyaci
Copy link
Contributor

Closes #4026

I do not know do I need to change another file(s) because PrimeReact's structure is changed a lot (from my side).
Let me know if I need to change another file(s)

@vercel
Copy link

vercel bot commented Feb 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) May 9, 2023 2:51pm

@EmirBoyaci
Copy link
Contributor Author

Hi @melloware you approved PR but did not merged. I just wanted to know, did you forget or it was on purpose?

@melloware
Copy link
Member

Yes PrimeTek is working on refactoring right now and they asked me not to merge anything until they are done. So it will get merged eventually!

@EmirBoyaci
Copy link
Contributor Author

When refactoring is done, could you please ping me so that I can resolve conflicts in my PR? Thank you!

@melloware
Copy link
Member

OK looks like some conflicts to resolve?

@EmirBoyaci
Copy link
Contributor Author

OK looks like some conflicts to resolve?

It seems it is working but I'm getting error in console. No idea for now how to fix.

image

@melloware
Copy link
Member

I will take a look

@melloware
Copy link
Member

OK I juts committed a fix on your branch trying to fix the issue if you want to pull it.

@EmirBoyaci
Copy link
Contributor Author

OK I juts committed a fix on your branch trying to fix the issue if you want to pull it.

It seems error is now not present. Thanks for your co-working! 👀

@melloware melloware merged commit 3055f41 into primefaces:master May 9, 2023
@EmirBoyaci EmirBoyaci deleted the ISSUE-4026 branch May 9, 2023 14:59
@EmirBoyaci
Copy link
Contributor Author

@melloware just to know I want to ask a question, I know the question is not related about this topic but I didn't wanted to create a issue for that. In MultiSelect component, we can get the selected values as array in onChange event but we're not getting the selected value AFAIK. Is it possible to get the selected value now? If not, I think it is doable feature and I can create an issue and suggest a PR for that.

@melloware
Copy link
Member

yep please create an issue and PR for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown: Footer Template
2 participants