-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add panel footer to dropdown component #4027
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Hi @melloware you approved PR but did not merged. I just wanted to know, did you forget or it was on purpose? |
Yes PrimeTek is working on refactoring right now and they asked me not to merge anything until they are done. So it will get merged eventually! |
When refactoring is done, could you please ping me so that I can resolve conflicts in my PR? Thank you! |
OK looks like some conflicts to resolve? |
I will take a look |
OK I juts committed a fix on your branch trying to fix the issue if you want to pull it. |
It seems error is now not present. Thanks for your co-working! 👀 |
@melloware just to know I want to ask a question, I know the question is not related about this topic but I didn't wanted to create a issue for that. In MultiSelect component, we can get the selected values as array in |
yep please create an issue and PR for review. |
Closes #4026
I do not know do I need to change another file(s) because PrimeReact's structure is changed a lot (from my side).
Let me know if I need to change another file(s)