Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast: close icon fixed #3371

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Toast: close icon fixed #3371

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3415276
Toast close icon fixed
bahadirsofuoglu Sep 27, 2022
c3a7f20
Lint issue
bahadirsofuoglu Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions components/lib/toast/ToastMessage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,12 @@ export const ToastMessage = React.memo(
const createCloseIcon = () => {
if (closable !== false) {
return (
<button type="button" className="p-toast-icon-close p-link" onClick={onClose} aria-label={localeOption('close')}>
<span className="p-toast-icon-close-icon pi pi-times" aria-hidden="true"></span>
<Ripple />
</button>
<div>
<button type="button" className="p-toast-icon-close p-link" onClick={onClose} aria-label={localeOption('close')}>
<span className="p-toast-icon-close-icon pi pi-times" aria-hidden="true"></span>
<Ripple />
</button>
</div>
);
}

Expand Down