Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3171: ScrollPanel Cannot scroll inside dialog #3282

Merged
merged 3 commits into from
Sep 12, 2022
Merged

Fix #3171: ScrollPanel Cannot scroll inside dialog #3282

merged 3 commits into from
Sep 12, 2022

Conversation

habubey
Copy link
Contributor

@habubey habubey commented Sep 10, 2022

Defect Fixes

Fixed bugs when converting from class comp. to functional comp.

@mertsincan
Copy link
Member

mertsincan commented Sep 10, 2022 •
edited
Loading

Good catch! @habubey please resolve conflicts ;)

@melloware
Copy link
Member

I just fixed the conflict :)

@melloware
Copy link
Member

Build is rerunning now

@melloware melloware linked an issue Sep 10, 2022 that may be closed by this pull request
ScrollPanel: Cannot scroll inside dialog #3171
Closed
@melloware
Copy link
Member

OK just need to run npm run format on it to format it.

@habubey
Copy link
Contributor Author

habubey commented Sep 10, 2022 •
edited
Loading

OK just need to run npm run format on it to format it.

Done ✅

@melloware melloware added the Core Team Issue or pull request has been *opened* by a member of Core Team label Sep 10, 2022
@melloware melloware merged commit 419255b into primefaces:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertsincan mertsincan mertsincan approved these changes

@melloware melloware melloware approved these changes

Assignees
No one assigned
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScrollPanel: Cannot scroll inside dialog
3 participants
@habubey @mertsincan @melloware