Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #3196: Message: Override Icon using icon attribute #3214

Closed
wants to merge 6 commits into from

Conversation

habubey
Copy link
Contributor

@habubey habubey commented Aug 31, 2022

Defect Fixes

Added new icon attribute on component.

Feature Requests

Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.

Copy link
Member

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have a better fix for this.

@mertsincan mertsincan added the Core Team Issue or pull request has been *opened* by a member of Core Team label Aug 31, 2022
@habubey habubey changed the title Fixed #3196 issue Fixed #3196: Message: Override Icon using icon attribute Sep 1, 2022
@melloware
Copy link
Member

@habubey see my proper PrimeReact way of adding this feature: #3224

@melloware melloware closed this Sep 1, 2022
@mertsincan mertsincan deleted the Fixed-#3196-Issue branch February 15, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants