New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3059: ChartJS allow loading by script tag #3061

Merged

melloware merged 1 commit into primefaces:master from melloware:PR3059

Jul 14, 2022

Member

melloware commented Jul 14, 2022 •

edited

Loading

###Defect Fixes
Fix #3059: ChartJS allow loading by script tag

Dynamically checks and prevents name collision with Chart to allow loading from script.

 <script src="https://cdnjs.cloudflare.com/ajax/libs/Chart.js/3.8.0/chart.min.js" crossorigin="anonymous"></script>
<script src="https://unpkg.com/primereact/core/core.min.js"></script>
<script src="https://unpkg.com/primereact/chart/chart.min.js" crossorigin="anonymous"></script>

melloware force-pushed the PR3059 branch from 1a033b0 to 369331a Compare

July 14, 2022 14:24


          Fix primefaces#3059: ChartJS allow loading by script tag

2edb189

melloware force-pushed the PR3059 branch from 369331a to 2edb189 Compare

July 14, 2022 14:31

melloware merged commit b8b2964 into primefaces:master

melloware deleted the PR3059 branch

July 14, 2022 14:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet