Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3023: Sort nulls like Excel by default at bottom #3026

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

melloware
Copy link
Member

###Feature Requests
Fix #3023: Sort nulls like Excel by default at bottom

This always sorts NULLs at the bottom which is the way Excel does it by default.

@melloware melloware added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jul 3, 2022
@mertsincan mertsincan merged commit a8a50f0 into primefaces:master Jul 4, 2022
@mertsincan
Copy link
Member

Thanks @melloware ;)

@melloware melloware deleted the PR3023 branch July 4, 2022 12:01
@kbeeveer46
Copy link

Is there any way to enable the old setting where nulls are at the beginning in ascending order? I hope so. We've been telling our clients how to use the table and how it functions and now they are going to assume there are no nulls. Especially if there's 50+ pages of data. They're not going to know the nulls are on page 50 at the end. This is not something that should be changed without providing a setting to use the old method.

@melloware
Copy link
Member Author

@kbeeveer46 can you open a new issue please. Since this sort mechanism is used across multiple components I am wondering if we can make it a global setting like PrimeReact.sortNullsHigh = true;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataTable: Incorrect order by ASC (empty values are at the beginning)
3 participants