Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SelectItem import statement #2944

Merged
merged 1 commit into from
May 30, 2022
Merged

Conversation

Ruan20795
Copy link
Contributor

The actual file name when pulling from npm is "selectitem" and not "SelectItem", so when running builds on case sensitive OS, the build fails:

image

The actual file name when pulling from npm is "selectitem" and not "SelectItem", so when running builds on case sensitive OS, the build fails
@tamnguyen02121993
Copy link

I also have trouble same above issue. So please help me resolve it

@melloware melloware added the Typescript Issue or pull request is *only* related to TypeScript definition label May 30, 2022
@melloware melloware added this to the 8.2.0 milestone May 30, 2022
@melloware
Copy link
Member

I am not seeing this issue in my IDE VS Code? It is saying SelectItem is correct and not selectitem

@melloware
Copy link
Member

OK I see I am on Windows which is not case sensitive. Thank you for reporting!

@melloware
Copy link
Member

Can you also fix CascadeSelect, ListBox, MultiSelect and SelectButton they all have the exact same issue.

@melloware
Copy link
Member

Nevermind i will fix with another PR.

@melloware melloware merged commit 92536f8 into primefaces:master May 30, 2022
@melloware
Copy link
Member

OK I fixed the other imports as well!

@Ruan20795 Ruan20795 deleted the patch-1 branch May 31, 2022 11:24
@Ruan20795
Copy link
Contributor Author

@melloware I see that was tagged with milestone 8.2.0? This is clearly a bug and preventing builds on CI/CD workflows. Can this not be pushed as a bug fix?

@melloware
Copy link
Member

@Ruan20795 I don't work for PrimeTek I am just an open source committer. How and when they do releases is up to Primetek.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants