Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2797: Chips add onKeyDown and KeyFilter #2798

Merged
merged 5 commits into from
Jul 1, 2022

Conversation

melloware
Copy link
Member

@melloware melloware commented Apr 25, 2022

###Feature Requests
Fix #2797: Chips add onKeyDown callback and KeyFilter ability

Give the user a chance to intercept and prevent keys. For example...

    const onKeyDown = (event) => {
        if (event.which === 65) {
            event.preventDefault();
        }
    }

@melloware melloware requested a review from mertsincan April 25, 2022 13:24
@melloware melloware added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Apr 25, 2022
@melloware melloware changed the title Fix #2797: Chips add onKeyDown callback Fix #2797: Chips add onKeyDown and KeyFilter Apr 25, 2022
@mertsincan mertsincan added the Status: Discussion Issue or pull request needs to be discussed by Core Team label May 9, 2022
@mertsincan
Copy link
Member

Wow! Is it work? @melloware. If yes, please merge it asap :)

@melloware
Copy link
Member Author

Yep this works great! Merging.

@melloware melloware merged commit 7d89754 into primefaces:master Jul 1, 2022
@melloware melloware deleted the PR2797 branch July 1, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chips: Add onKeyDown and KeyFilter
2 participants