Fix #1661: Calendar do not navigate past min and max #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
added
the
Status: Pending Review
|
@melloware, Thanks a lot for this PR! You need to add a property to Calendar for this. We should not break the current default behavior. This feature is optional. |
|
I picked |
melloware
added
Resolution: Needs Revision
melloware
added
Status: Pending Review
|
Maybe, its name can be 'showMinMaxRange' and the default value is 'false' to be compatible with other Prime* libraries. WDYT? |
|
OK updated to |
|
Thanks @melloware ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###Defect Fixes
Fix #1661: Calendar do not navigate past min and max
@mertsincan this actually is much easier now that you switched to hooks because I can put this code in one place when the overlay panel renders and update the navigators appropriately without and additional property.