Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2616: avoid TypeError #2617

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Fix #2616: avoid TypeError #2617

merged 1 commit into from
Feb 17, 2022

Conversation

kalinkrustev
Copy link
Contributor

@kalinkrustev kalinkrustev commented Jan 29, 2022 •
edited
Loading

Fixes #2616

@melloware
Copy link
Member

This seems like a safe check. Does this happen in real code or only in Jest tests?

@kalinkrustev
Copy link
Contributor Author

It is likely to happen only in tests, but may also happen in other cases which use jsdom. Maybe SSR.

@mertsincan mertsincan merged commit 8372022 into primefaces:master Feb 17, 2022
@mertsincan
Copy link
Member

Hi @kalinkrustev,

Thanks a lot for your contribution!

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automated tests throw "TypeError: highlightItem.scrollIntoView is not a function"
3 participants
@kalinkrustev @melloware @mertsincan