Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2532 InputNumber fix, fixed inputnumber to dont accept put letter on input #2533

Closed
wants to merge 2 commits into from

Conversation

IHPNULL
Copy link

@IHPNULL IHPNULL commented Dec 16, 2021

###Defect Fixes
#2532
###Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.

@melloware
Copy link
Member

This won't handle special chars like accent and umlaut right?

à, è, ì, ò, ù,

ã, ñ, õ

ä, ë, ï, ö, ü, ÿ,

@IHPNULL
Copy link
Author

IHPNULL commented Dec 16, 2021

This won't handle special chars like accent and umlaut right?

à, è, ì, ò, ù,

ã, ñ, õ

ä, ë, ï, ö, ü, ÿ,

u're right, i'm going to fix it

@IHPNULL
Copy link
Author

IHPNULL commented Dec 16, 2021

I already did the fix, please review asap 🙂

@melloware
Copy link
Member

I just checked it with Regex101 here: https://regex101.com/r/62wB81/1/

Looks good to me!

@IHPNULL
Copy link
Author

IHPNULL commented Dec 16, 2021

WOW u're fast shuashuahusahuashuahsuha

@melloware
Copy link
Member

This is what code reviews are for 😄

@IHPNULL IHPNULL changed the title InputNumber fix, fixed inputnumber to dont accept put letter on input Fix #2532 InputNumber fix, fixed inputnumber to dont accept put letter on input Feb 3, 2022
@IHPNULL
Copy link
Author

IHPNULL commented Mar 7, 2022

issue fixed

@IHPNULL IHPNULL closed this Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants