Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "required" prop is not working on Dropdown #933

Closed
stripp915 opened this issue Jun 19, 2019 · 0 comments
Closed

The "required" prop is not working on Dropdown #933

stripp915 opened this issue Jun 19, 2019 · 0 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@stripp915
Copy link

I'm submitting a ... (check one with "x")

[x ] bug report

Current behavior
Using the 'required' attribute on a Dropdown component does not prevent a form from submitting, even when the dropdown value is empty.

Expected behavior
Either the 'required' attribute affects a form's validity, or the attribute is removed from this component.

This appears to have been removed on this commit: 5f2096e

The props still contain a 'required' attribute, but all references to that prop were removed from the rest of the component.

@mertsincan mertsincan self-assigned this Jun 20, 2019
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Jun 20, 2019
@mertsincan mertsincan added this to the 3.1.5 milestone Jun 20, 2019
@mertsincan mertsincan changed the title Dropdown required functionality removed The "required" prop is not working on Dropdown Jun 20, 2019
mertsincan added a commit that referenced this issue Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants