Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar time parsing broken for showSeconds == false #901

Closed
Mobe91 opened this issue May 25, 2019 · 0 comments
Closed

Calendar time parsing broken for showSeconds == false #901

Mobe91 opened this issue May 25, 2019 · 0 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@Mobe91
Copy link
Contributor

Mobe91 commented May 25, 2019

I'm submitting a ... (check one with "x")

[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)
Please fork the codesandbox below and create a case demonstrating your bug report. Issues without a codesandbox have much less possibility to be reviewed.

https://codesandbox.io/s/qjx332qq4

Current behavior
The parseTime function throws an exception when props.showSeconds is false. This causes the user input not to be parsed to a Date.

Expected behavior
The parseTime works when props.showSeconds is false.

Minimal reproduction of the problem with instructions
Just create a Calendar with showTime="true" but showSeconds="false" and try to manually type a date time string in the input field. The bound date value will a string and not a Date because parsing fails.

Please tell us about your environment:

  • PrimeReact version:
    3.1.3
Mobe91 added a commit to ordami/primereact that referenced this issue May 25, 2019
cagataycivici added a commit that referenced this issue May 30, 2019
…broken

Fixes #901 - fix calendar parseTime function when showSeconds is false
@cagataycivici cagataycivici self-assigned this May 30, 2019
@cagataycivici cagataycivici added the Type: Bug Issue contains a defect related to a specific component. label May 30, 2019
@cagataycivici cagataycivici added this to the 3.1.4 milestone May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants