Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataView: listTemplate return type error #7102

Closed
T00rk opened this issue Sep 2, 2024 · 2 comments · Fixed by #7105 · May be fixed by leoo1992/GeradorQRCode#95
Closed

DataView: listTemplate return type error #7102

T00rk opened this issue Sep 2, 2024 · 2 comments · Fixed by #7105 · May be fixed by leoo1992/GeradorQRCode#95
Assignees
@melloware
Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Milestone
10.8.3

Comments

@T00rk
Copy link

T00rk commented Sep 2, 2024

Describe the bug

DataView listTemplate has the return type ReactNode[] which raises and error in VSCode.
I'm pretty sure the return type should be ReactNode or maybe ReactNode | ReactNode[]

Reproducer

No response

System Information

primereact: 10.8.2

Steps to reproduce the behavior

No response

Expected behavior

No response
@T00rk T00rk added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 2, 2024
@Rekl0w
Copy link
Contributor

Rekl0w commented Sep 3, 2024

There is an example that works with no errors. Can you provide a stackblitz link that exact problem ?

@melloware melloware added Typescript Issue or pull request is *only* related to TypeScript definition and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 3, 2024
@melloware melloware self-assigned this Sep 3, 2024
@melloware melloware added this to the 10.8.3 milestone Sep 3, 2024
melloware added a commit to melloware/primereact that referenced this issue Sep 3, 2024
@melloware
Fix primefaces#7102: DataView fix listTemplate typescript def
d65a694
@melloware melloware mentioned this issue Sep 3, 2024
Merged
@melloware
Copy link
Member

Thanks for the report PR submitted

melloware added a commit to melloware/primereact that referenced this issue Sep 3, 2024
@melloware
Fix primefaces#7102: DataView fix listTemplate typescript def
998b72e
melloware added a commit to melloware/primereact that referenced this issue Sep 3, 2024
@melloware
Fix primefaces#7102: DataView fix listTemplate typescript def
6b30c49
@leoo1992 leoo1992 mentioned this issue Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
10.8.3
3 participants
@T00rk @melloware @Rekl0w