-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Column: PT not getting applied for headerCheckbox #7050
Column: PT not getting applied for headerCheckbox #7050
Comments
Please fork the Stackblitz project and create a case demonstrating your bug report. This issue will be closed if no activities in 20 days. |
cc @peconomou929 since we just fixed this can you help out @skj-skj ? |
Hi @melloware, I created a Stackblitz project for this issue. In this project, I updated the style of the checkboxes using PrimeFlex classes. In the Click on checkbox on the table header to view the behaviour. |
Thanks I will take a look. |
I agree that this is a bug, and what you demonstrate is indeed unexpected behaviour. However, another way to achieve what you want is to use the "column" entry in the DataTablePassThroughOptions, instead of setting the ColumnPassThroughOptions on the Column itself. That usage is precisely what got fixed in #6979 and #6939. |
Oh i see there is a |
@peconomou929 Thanks that workaround works. this pattern makes sense as in most cases a DataTable will have only one column as checkbox. so instead of pt individual column for |
yeah now i am wondering if headerCheckbox should be removed from the |
OK PR submitted |
@melloware thanks for taking care of this issue. |
Describe the bug
according to the docs for Column PT
https://primereact.org/datatable/#pt.column.options
headerCheckbox is available to pass props to Checkbox component but props are not getting applied.
I saw there was similar issue which was fixed #6978 but the file change were in DataTable which doesn't have headerCheckbox pt as per docs
Reproducer
Stackblitz Project with headerCheckbox issue
System Information
PrimeReact: 10.8.2
React: 18.3.1
Vite: 5.4.0
Steps to reproduce the behavior
No response
Expected behavior
props should passed to the checkbox component of headerCheckbox
The text was updated successfully, but these errors were encountered: