Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputOtp: Passthrough options type and missing docs #7032

Closed
ivanpajon opened this issue Aug 12, 2024 · 0 comments · Fixed by #7033 · May be fixed by leoo1992/GeradorQRCode#95
Closed

InputOtp: Passthrough options type and missing docs #7032

ivanpajon opened this issue Aug 12, 2024 · 0 comments · Fixed by #7033 · May be fixed by leoo1992/GeradorQRCode#95
Assignees
@ivanpajon
Labels
Component: Tailwind Tailwind specific issue Component: Unstyled Issue related to unstyled/passthrough attributes
Milestone
10.8.3

Comments

@ivanpajon
Copy link
Contributor

ivanpajon commented Aug 12, 2024 •
edited
Loading

Describe the bug

Related to #6938

Also there are some more missing things:

  • Unstyled theming section in official docs InputOtp -> Theming
  • Default styles in Tailwind theme
  • Type definition for InputOtp in PrimeReactPTOptions

Reproducer

https://stackblitz.com/edit/dthn9t?file=src%2Fmain.tsx

System Information

  • System:

OS: Windows 11 10.0.22631
CPU: (20) x64 12th Gen Intel(R) Core(TM) i9-12900HK
Memory: 33.95 GB / 63.71 GB

  • Binaries:

Node: 22.4.1 - ~\AppData\Local\nvs\default\node.EXE
npm: 10.8.1 - ~\AppData\Local\nvs\default\npm.CMD
pnpm: 9.6.0 - ~\AppData\Local\pnpm\pnpm.CMD

  • Browsers:

Edge: Chromium (127.0.2651.74)
Internet Explorer: 11.0.22621.3527

  • npmPackages:

react: 18.3.1 => 18.3.1

Steps to reproduce the behavior

  • Unstyled theming section in official docs

  • Default styles in Tailwind theme

    • Go to exported Tailwind theme and search for inputotp

  • Type definition for InputOtp in PrimeReactPTOptions

    • Go to exported PrimeReactPTOptions and search for inputotp

Expected behavior

InputOtp component having theming section for unstyled mode.
Existing default styles in Tailwind theme.
Existing definition for InputOtp in PrimeReactPTOptions.
@ivanpajon ivanpajon added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 12, 2024
@melloware melloware added Component: Tailwind Tailwind specific issue Component: Unstyled Issue related to unstyled/passthrough attributes and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 12, 2024
@ivanpajon ivanpajon mentioned this issue Aug 12, 2024
Merged
@melloware melloware added this to the 10.8.3 milestone Aug 12, 2024
melloware pushed a commit that referenced this issue Aug 12, 2024
@ivanpajon
Fix #7032: Passthrough options type and missing docs (#7033)
4da5a7b 
* fix: InputOTP passthrough type definition

* chore: Add section for theming in unstyled mode

* chore: Add default styles to Tailwind theme

* chore: Add inputotp to PrimeReactPTOptions
@leoo1992 leoo1992 mentioned this issue Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanpajon ivanpajon

Labels
Component: Tailwind Tailwind specific issue Component: Unstyled Issue related to unstyled/passthrough attributes
Projects
None yet
Milestone
10.8.3
2 participants
@melloware @ivanpajon