Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeTable: TreeTableColumnResizeEndEvent do not match type #6881

Closed
wonlee6 opened this issue Jul 14, 2024 · 1 comment · Fixed by #6886, leoo1992/GeradorQRCode#80 or leoo1992/GeradorQRCode#85 · May be fixed by mtech-31-quemistry/quemistry_client_web#20
Closed

TreeTable: TreeTableColumnResizeEndEvent do not match type #6881

wonlee6 opened this issue Jul 14, 2024 · 1 comment · Fixed by #6886, leoo1992/GeradorQRCode#80 or leoo1992/GeradorQRCode#85 · May be fixed by mtech-31-quemistry/quemistry_client_web#20
Assignees
@melloware
Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Milestone
10.8.0

Comments

@wonlee6
Copy link

wonlee6 commented Jul 14, 2024

Describe the bug

According to the TreeTableColumnResizeEndEvent type definition:

interface TreeTableColumnResizeEndEvent {
    element: HTMLElement;

    column: ColumnProps;

    delta: number;
}

However, I believe the correct type should be:

     element: HTMLElement;

     column: React.ReactElement;

     delta: number;
image

Reproducer

https://stackblitz.com/edit/5hjjwp?file=src%2FApp.tsx,node_modules%2Fprimereact%2Ftreetable%2Ftreetable.d.ts

PrimeReact version

10.7.0

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

chrome

Steps to reproduce the behavior

No response

Expected behavior

No response
@wonlee6 wonlee6 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 14, 2024
@melloware melloware added Typescript Issue or pull request is *only* related to TypeScript definition and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 14, 2024
melloware added a commit to melloware/primereact that referenced this issue Jul 14, 2024
@melloware
Fix primefaces#6881: TreeTable onResizeEnd incorrect column value
4dd36ea
@melloware melloware mentioned this issue Jul 14, 2024
Merged
@melloware
Copy link
Member

PR Submitted it should have been the whole Column component and not ColumnProps.

@melloware melloware self-assigned this Jul 14, 2024
@melloware melloware added this to the 10.7.1 milestone Jul 14, 2024
@leoo1992 leoo1992 mentioned this issue Aug 19, 2024
Merged
@leoo1992 leoo1992 mentioned this issue Aug 27, 2024
Merged
@raymondhtet raymondhtet mentioned this issue Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
10.8.0
2 participants
@melloware @wonlee6