Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeTable: onFilter callback has wrong argument type #6836

Closed
schlangguru opened this issue Jul 4, 2024 · 1 comment · Fixed by #6837, leoo1992/GeradorQRCode#80 or leoo1992/GeradorQRCode#85 · May be fixed by mtech-31-quemistry/quemistry_client_web#20
Closed

TreeTable: onFilter callback has wrong argument type #6836

schlangguru opened this issue Jul 4, 2024 · 1 comment · Fixed by #6837, leoo1992/GeradorQRCode#80 or leoo1992/GeradorQRCode#85 · May be fixed by mtech-31-quemistry/quemistry_client_web#20
Assignees
@melloware
Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Milestone
10.8.0

Comments

@schlangguru
Copy link

Describe the bug

the onFilter callback of the TreeTable has wrong type definitions.
Current type definitions is: onFilter?(filters: TreeTableFilterMeta[]): void; but the onFilter callback is not called with an object of type TreeTableFilterMeta[].

Reproducer

https://stackblitz.com/edit/qs2rlx?file=src%2FApp.tsx

PrimeReact version

10.3.1

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@schlangguru schlangguru added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 4, 2024
@melloware melloware added Typescript Issue or pull request is *only* related to TypeScript definition and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 4, 2024
melloware added a commit to melloware/primereact that referenced this issue Jul 4, 2024
@melloware
Fix primefaces#6836: TreeTable onFilter type def
f212659
@melloware melloware self-assigned this Jul 4, 2024
@melloware melloware added this to the 10.7.1 milestone Jul 4, 2024
@melloware melloware mentioned this issue Jul 4, 2024
Merged
@melloware
Copy link
Member

You are correct. PR submitted.

@leoo1992 leoo1992 mentioned this issue Aug 19, 2024
Merged
@leoo1992 leoo1992 mentioned this issue Aug 27, 2024
Merged
@raymondhtet raymondhtet mentioned this issue Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
10.8.0
2 participants
@schlangguru @melloware