Toast and message onRemove argument is not a ToastMessage type when it has _pId

[lukelalo]

Describe the bug

Hi,

I've seen some changes in toast/message code and I think these changes may have broken the onRemove call parameters:

In the first call to onRemove it may not have the ._pId attribute, but in the second call it has it, and instead of sending the ToastMessage in onRemove function it returns the _pId.

I think the onRemove call should be called with messageInfo.message || messageInfo instead of removeMessage.

Regards
Pablo García

Reproducer

No response

PrimeReact version

10.6.6

React version

17.x

Language

ES6

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

• Create a Toast or Message
• Show the message
• Click on onRemove button (it contains a message as first parameter)
• Show the message again
• Click on onRemove button (it contains a number as first parameter)

Expected behavior

• Create a Toast or Message
• Show the message
• Click on onRemove button (it contains a message as first parameter)
• Show the message again
• Click on onRemove button (it contains a message as first parameter)

[melloware]

@Rekl0w i think he means this fix: #6457

[melloware]

Agreed you should be able to do this...

toastRef.current.remove({ id: messageId  });

but that is not working.

[lukelalo]

My main issue is I don't know what to do with the _pId, as I have all the information in my process stored on the ToastMessage, and also receiving two distinct arguments in the same function is some sort of... messy

[lukelalo]

@Rekl0w i think he means this fix: #6457

Yes

[melloware]

@lukelalo here is a demo i did for another user that works but it requires you to keep the message to remove it.

https://stackblitz.com/edit/gque6v?file=src%2FApp.jsx

[lukelalo]

Yep, but this demo doesn't use the onRemove method. As a workaround is not bad, but shouldn't be awesome that the onRemove method did its work?

[melloware]

yeah your issue is definitely a bug.

[elvis1994]

Hi, I also experimenting a bug due to this issue. Only at first interaction with close, the argument passed to the remove function is the entire message object instead of a pId, which cause the remove of all messages which are the same. From the second interaction the argument is a pId and the close action works correctly, only the specific message with that pId is removed.

[lukelalo]

Similar to #5972