-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Password: iconField pt not passing through #6776
Comments
Any updates on this? Looking at the code, I can't really figure out how can I start understanding/debugging this. If anyone can guide me I would be happy to submit a PR fix. Thanks. |
I didn't take a deep look at this but maybe studying a component it does work for like |
The I think I will add some console.logs and try again. if you have any hints/things I can look at it please do tell. |
luckily you can run |
Ensure `InputIcon` can be styled when in unstyled mode
Please check out the attached stackBlitz -> https://stackblitz.com/edit/5npj6y?file=src%2FApp.jsx tl;dr |
I opened the stackblitz you linked and tried my original use case which I mentioned in #7236. Basically left aligning the icon by adding the If I understand correctly it's the |
The stackblitz I provided is not using any custom logic, it is showing an example that you can style the iconfield. It is also demonstrating that you can not currently style inputIcon. When I am available I will send you a demonstration with a left aligned icon
Best,
Jared Scott
Founder | Variable
+1 (562) 302-8063
+886966463236
…________________________________
From: Mohamed Emad ***@***.***>
Sent: Wednesday, September 25, 2024 5:18:40 PM
To: primefaces/primereact ***@***.***>
Cc: Jared Scott ***@***.***>; Comment ***@***.***>
Subject: Re: [primefaces/primereact] Password: iconField pt not passing through (Issue #6776)
I opened the stackblitz you linked and tried my original use case which I mentioned in #7236<#7236>. Basically left aligning the icon by adding the p-icon-field-left to the iconField. It unfortunately didn't work. Maybe the iconField respects styles but adding p-icon-field-left didn't yield the result I expect it to. Which I am not exactly clear on why that's the case?
Could you perhaps offer an explanation? I should mention that it does work in #7248<#7248>.
If I understand correctly it's the iconField which enforces the alignment of the icon and not the inputIcon itself.
is that correct?
thanks.
—
Reply to this email directly, view it on GitHub<#6776 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAD7NR4KSTTRY5RK44APKVDZYJ5XBAVCNFSM6AAAAABJTXFDN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZTGUZDONJYGQ>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Hey @gcko would you kindly point me to a demonstration with a left aligned icon? thank you |
Describe the bug
Attributes to IconField via pt do not apply.
Reproducer
https://stackblitz.com/edit/anf38x?file=src%2FApp.jsx
PrimeReact version
10.6.6
React version
18.x
Language
TypeScript
Build / Runtime
Create React App (CRA)
Browser(s)
No response
Steps to reproduce the behavior
No response
Expected behavior
I expect the attribute i pass through to be applied
The text was updated successfully, but these errors were encountered: