Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable: editor is still activated on cell click when editMode is off #6735

Closed
MarcinKoziuk opened this issue Jun 7, 2024 · 1 comment · Fixed by #6736, leoo1992/GeradorQRCode#57 or leoo1992/GeradorQRCode#80 · May be fixed by nhattpn/BTL_LTNC#56
Closed

DataTable: editor is still activated on cell click when editMode is off #6735

MarcinKoziuk opened this issue Jun 7, 2024 · 1 comment · Fixed by #6736, leoo1992/GeradorQRCode#57 or leoo1992/GeradorQRCode#80 · May be fixed by nhattpn/BTL_LTNC#56
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.7.0

Comments

@MarcinKoziuk
Copy link

Describe the bug

If a <Column /> is configured with an editor, the editor is still activated on click regardless of the editMode setting. Also, some weird behaviour occurs in this situation, more than one cell editor can appear.

Reproducer

https://stackblitz.com/edit/vitejs-vite-iibrgb?file=src%2FApp.tsx

PrimeReact version

10.6.6

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

  • set <DataTable />'s editMode to null, undefined or remove the property
  • configure <Column />s with an editor
  • click on a cell

Expected behavior

The cell's editor should not appear on click unless editMode is "cell"
@MarcinKoziuk MarcinKoziuk added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 7, 2024
melloware added a commit to melloware/primereact that referenced this issue Jun 7, 2024
@melloware
Fix primefaces#6735: Datatable respect editMode to determine if editable
0fe1c7b
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 7, 2024
@melloware melloware added this to the 10.7.0 milestone Jun 7, 2024
@melloware melloware self-assigned this Jun 7, 2024
@melloware melloware mentioned this issue Jun 7, 2024
Merged
@melloware
Copy link
Member

Thanks for reporting. PR submitted.

melloware added a commit that referenced this issue Jun 7, 2024
@melloware
Fix #6735: Datatable respect editMode to determine if editable (#6736)
93163ad
@nhattpn nhattpn mentioned this issue Jul 25, 2024
Open
@leoo1992 leoo1992 mentioned this issue Jul 25, 2024
Merged
@leoo1992 leoo1992 mentioned this issue Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.7.0
2 participants
@MarcinKoziuk @melloware