Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable: Column with selectionMode not setting correctly the aria-label. #6706

Closed
muhtomakin opened this issue May 29, 2024 · 3 comments · Fixed by #6707, leoo1992/GeradorQRCode#57 or leoo1992/GeradorQRCode#80 · May be fixed by nhattpn/BTL_LTNC#56
Closed

DataTable: Column with selectionMode not setting correctly the aria-label. #6706

muhtomakin opened this issue May 29, 2024 · 3 comments · Fixed by #6707, leoo1992/GeradorQRCode#57 or leoo1992/GeradorQRCode#80 · May be fixed by nhattpn/BTL_LTNC#56
Assignees
@melloware
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Milestone
10.7.0

Comments

@muhtomakin
Copy link

Describe the bug

I am using the DataTable and Column with selectionMode="multiple". I see that there is no way to change the aria-label. I used also selectionAriaLabel={(rowData) => rowData.id} to configure the aria-albel for checkboxes. But still there is undefined inside of aria-label.

aria-label="undefined Name"

Reproducer

No response

PrimeReact version

10.6.6

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@muhtomakin muhtomakin added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 29, 2024
@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 29, 2024
@melloware melloware self-assigned this May 29, 2024
@melloware melloware added this to the 10.7.0 milestone May 29, 2024
@melloware
Copy link
Member

its a field in the JSON so just do selectionAriaLabel="id".

@melloware
Copy link
Member

And there is a bug.

melloware added a commit to melloware/primereact that referenced this issue May 29, 2024
@melloware
Fix primefaces#6706: Datatable selection aria locale label
84be47a
@melloware melloware mentioned this issue May 29, 2024
Merged
melloware added a commit that referenced this issue May 29, 2024
@melloware
Fix #6706: Datatable selection aria locale label (#6707)
5feb844
@melloware
Copy link
Member

see my PR the ARIA label was wrong it it comes from PrimeLocales for your language.

See: https://github.com/primefaces/primelocale

@nhattpn nhattpn mentioned this issue Jul 25, 2024
Open
@leoo1992 leoo1992 mentioned this issue Jul 25, 2024
Merged
@leoo1992 leoo1992 mentioned this issue Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Projects
None yet
Milestone
10.7.0
2 participants
@melloware @muhtomakin