Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip: Escape key not dismissing tooltip (WCAG 2.1 1.4.13) #6680

Closed
kishore5242 opened this issue May 27, 2024 · 2 comments · Fixed by #6687, leoo1992/GeradorQRCode#57 or leoo1992/GeradorQRCode#80 · May be fixed by nhattpn/BTL_LTNC#56
Closed

Tooltip: Escape key not dismissing tooltip (WCAG 2.1 1.4.13) #6680

kishore5242 opened this issue May 27, 2024 · 2 comments · Fixed by #6687, leoo1992/GeradorQRCode#57 or leoo1992/GeradorQRCode#80 · May be fixed by nhattpn/BTL_LTNC#56
Assignees
@akshayaqburst
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Milestone
10.7.0

Comments

@kishore5242
Copy link

Describe the bug

The tooltip displayed may obscure adjacent contents and user may want to dismiss it by pressing Esc key without moving the mouse.

image

image

image

Prime React document also says that we support escape key.
image

Also as per WCAG 1.4.13 -
image

Reproducer

https://stackblitz.com/edit/vitejs-vite-sihhuh?file=src%2FApp.tsx

PrimeReact version

10.5.3

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Hover over a component that displays a Tooltip
  2. Try to dismiss the tooltip by pressing escape key

Expected behavior

escape key closes the Tooltip
@kishore5242 kishore5242 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 27, 2024
@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 27, 2024
@melloware
Copy link
Member

Thanks for reporting. Definitely a missing feature.

@akshayaqburst
Copy link
Contributor

akshayaqburst commented May 27, 2024 •
edited
Loading

Created a PR for the issue.
Anyway, We have to explicitly specify closeOnEscape in the tooltipOptions prop, which is already specified in the documentation.

            <InputText value={value} onChange={(e) => setValue(e.target.value)}  tooltip="tooltip content" tooltipOptions={{closeOnEscape: true}} />

akshayaqburst pushed a commit to qburst/primereact_qb_31 that referenced this issue May 27, 2024
fix: primefaces#6680, Tooltip: Escape key not dismissing tooltip (WCA…
7e5694f 
…G 2.1 1.4.13)
@akshayaqburst akshayaqburst mentioned this issue May 27, 2024
Merged
akshayaqburst pushed a commit to qburst/primereact_qb_31 that referenced this issue May 27, 2024
fix: primefaces#6680, Tooltip: Escape key not dismissing tooltip (WCA…
17317d6 
…G 2.1 1.4.13)
akshayaqburst pushed a commit to qburst/primereact_qb_31 that referenced this issue May 27, 2024
fix: primefaces#6680, Tooltip: Escape key not dismissing tooltip (WCA…
68a69dc 
…G 2.1 1.4.13)
akshayaqburst pushed a commit to qburst/primereact_qb_31 that referenced this issue May 27, 2024
fix: primefaces#6680, Tooltip: Escape key not dismissing tooltip (WCA…
fa5bc50 
…G 2.1 1.4.13)
akshayaqburst pushed a commit to qburst/primereact_qb_31 that referenced this issue May 27, 2024
fix: primefaces#6680, Tooltip: Escape key not dismissing tooltip (WCA…
9c7b897 
…G 2.1 1.4.13)
melloware pushed a commit that referenced this issue May 27, 2024
@akshayaqburst
fix: #6680, Tooltip: Escape key not dismissing tooltip (WCAG 2.1 1.4.…
f5237b1 
…13) (#6687)
@melloware melloware added this to the 10.7.0 milestone May 27, 2024
@nhattpn nhattpn mentioned this issue Jul 25, 2024
Open
@leoo1992 leoo1992 mentioned this issue Jul 25, 2024
Merged
@leoo1992 leoo1992 mentioned this issue Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshayaqburst akshayaqburst

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Projects
None yet
Milestone
10.7.0
3 participants
@melloware @kishore5242 @akshayaqburst