Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitter/SplitterPanel: Unable to support divider dragging for more than two SplitterPanels in a Splitter component #6487

Closed
pcioffi-rtts opened this issue Apr 26, 2024 · 1 comment · Fixed by #6490
Closed

Splitter/SplitterPanel: Unable to support divider dragging for more than two SplitterPanels in a Splitter component #6487

pcioffi-rtts opened this issue Apr 26, 2024 · 1 comment · Fixed by #6490
Assignees
@KirilCycle
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.6.4

Comments

@pcioffi-rtts
Copy link

Describe the bug

Having a Splitter component with three or more panels under it causes issues when using the dividers for resizing; the left-most divider seems to work/behave fine, but upon using the right-most divider causes the left-most panel to resize wrongly (see gif for clarification)

PrimeReactSplitterThreePanelIssue

Reproducer

https://stackblitz.com/edit/draygx-s1dwup?file=src%2FApp.jsx

PrimeReact version

10.6.3

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@pcioffi-rtts pcioffi-rtts added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 26, 2024
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 27, 2024
@KirilCycle
Copy link
Contributor

KirilCycle commented Apr 28, 2024 •
edited
Loading

This happens because the 'onResizeEnd' method applies the wrong dimensions to the 'panelSizes' state. Let me try to fix it

@KirilCycle KirilCycle mentioned this issue Apr 28, 2024
Merged
@melloware melloware added this to the 10.6.4 milestone Apr 29, 2024
nitrogenous added a commit that referenced this issue Apr 30, 2024
@nitrogenous
Merge pull request #6490 from KirilCycle/fix/splitter-with-multi-panels
378a167 
Fix: #6487 Splitter can work with multiple panels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KirilCycle KirilCycle

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.6.4
Development

Successfully merging a pull request may close this issue.

Fix: #6487 Splitter can work with multiple panels KirilCycle/primereact
3 participants
@melloware @KirilCycle @pcioffi-rtts