Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete component doesn't appear to be adding key to auto complete items #6394

Closed
luke-denton-aligent opened this issue Apr 15, 2024 · 1 comment · Fixed by #6365
Closed

Autocomplete component doesn't appear to be adding key to auto complete items #6394

luke-denton-aligent opened this issue Apr 15, 2024 · 1 comment · Fixed by #6365
Labels
Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted
Milestone
10.6.4

Comments

@luke-denton-aligent
Copy link

Describe the bug

createListItem is being passed undefined for the key argument in AutoCompletePanel.js in a couple of places, which I assume is the root cause of a key not being placed on the rendered content

Reproducer

https://stackblitz.com/edit/pz5nwb?file=src%2FApp.jsx

PrimeReact version

10.6.3

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

  1. Load up stack blitz
  2. Open dev tools
  3. Type into the autocomplete field
  4. Notice the React warning about key missing

Expected behavior

React won't complain about the key prop missing from a list of items
@luke-denton-aligent luke-denton-aligent added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 15, 2024
@melloware
Copy link
Member

Already fixed with this PR: #6365

Duplicate of #6277 and #6317

@melloware melloware added Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 15, 2024
@melloware melloware mentioned this issue Apr 15, 2024
Merged
@melloware melloware added this to the 10.6.4 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted
Projects
None yet
Milestone
10.6.4
Development

Successfully merging a pull request may close this issue.

AutoComplete: Fix the issue of passing an undefined key while rendering lists. CodeElixir/primereact
2 participants
@melloware @luke-denton-aligent