Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: "enter" key broken in V10.5 #6277

Closed
shoreline2 opened this issue Apr 1, 2024 · 0 comments · Fixed by #6365
Closed

Autocomplete: "enter" key broken in V10.5 #6277

shoreline2 opened this issue Apr 1, 2024 · 0 comments · Fixed by #6365
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@shoreline2
Copy link

shoreline2 commented Apr 1, 2024

Describe the bug

Current behavior:

In version 10.5+, pressing "enter" results in the value prop being cleared and the popup is closed. The highlighted item is not selected.

Expected behavior:

In version 10.4, pressing "enter" selects the highlighted item and closes the popup if popup is visible.

Reproduction:
https://stackblitz.com/edit/jwpfxu?file=src%2FApp.jsx

I installed v10.4 by aliasing it as primereact-ten-four in the package file, and renamed the import as AutoCompleteTenFour.

Reproducer

https://stackblitz.com/edit/jwpfxu?file=src%2FApp.jsx

PrimeReact version

10.6.2

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://stackblitz.com/edit/jwpfxu?file=src%2FApp.jsx
  2. Observe there are two AutoComplete components rendered.
  • Observe the left instance is importing the component from version 10.4.
  • Observe the right instance is importing the component from version 10.6.2
  1. On the left component, type "alpha", press the down key on the keyboard once, and press enter.
  • Observe the AutoComplete value is alpha-0.
  1. On the right component, type "alpha", press the down key on the keyboard once, and press enter.
  • Observe the AutoComplete value is cleared.

Expected behavior

The expected behavior is the highlighted value is selected upon pressing the "enter" key.

@shoreline2 shoreline2 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 1, 2024
@shoreline2 shoreline2 changed the title [Autocomplete] "enter" key broken in V10.5 Autocomplete: "enter" key broken in V10.5 Apr 1, 2024
@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 6, 2024
@melloware melloware added this to the 10.6.4 milestone Apr 17, 2024
@nitrogenous nitrogenous added the Type: Bug Issue contains a defect related to a specific component. label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants