Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stepper: missing .p-component class for button.p-stepper-action #6339

Closed
dvpritzbuer opened this issue Apr 8, 2024 · 6 comments · Fixed by #6350 or leoo1992/GeradorQRCode#23
Closed

Stepper: missing .p-component class for button.p-stepper-action #6339

dvpritzbuer opened this issue Apr 8, 2024 · 6 comments · Fixed by #6350 or leoo1992/GeradorQRCode#23
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.6.4

Comments

@dvpritzbuer
Copy link
Contributor

Describe the bug

The .p-stepper-action button doesn't have the .p-component class like normal buttons have and so the font-family is not set correct and the user agent stylesheet is used for that value.

Reproducer

No response

PrimeReact version

10.6.2

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@dvpritzbuer dvpritzbuer added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 8, 2024
@dvpritzbuer
Copy link
Contributor Author

@melloware I checked "master" for that, so I don't think this is fixed already..

@melloware melloware self-assigned this Apr 9, 2024
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 9, 2024
@melloware melloware added this to the 10.6.4 milestone Apr 9, 2024
melloware added a commit to melloware/primereact that referenced this issue Apr 9, 2024
@melloware
Fix primefaces#6339: Stepper add p-component to Stepper action
b5880a9
@melloware melloware mentioned this issue Apr 9, 2024
Merged
@melloware
Copy link
Member

PR submitted!

@melloware
Copy link
Member

@dvpritzbuer 10.6.3 is out can you test and report back how Stepper is now or whether we need to open any more issues besides this one?

@dvpritzbuer
Copy link
Contributor Author

@melloware
I hope you haven't waited for an answer here and you can close this issue here since its fixed and I've already added my other issues, thx :)

@melloware
Copy link
Member

oh my PR for this one never got merged?

melloware added a commit that referenced this issue Apr 26, 2024
@melloware
Fix #6339: Stepper add p-component to Stepper action (#6350)
fb010b6
@dvpritzbuer
Copy link
Contributor Author

oh yeah true.. I've only clicked on the PR changes link and the added class was enough for me to declare it as fixed since the milestone here is set to 10.6.4 anyway =)

@leoo1992 leoo1992 mentioned this issue May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.6.4
2 participants
@melloware @dvpritzbuer