Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiSelect: loading prop in typescript shows error when called #6113

Closed
datacampsis opened this issue Mar 7, 2024 · 1 comment · Fixed by #6114
Closed

MultiSelect: loading prop in typescript shows error when called #6113

datacampsis opened this issue Mar 7, 2024 · 1 comment · Fixed by #6114
Assignees
@melloware
Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Milestone
10.5.2

Comments

@datacampsis
Copy link
Contributor

Describe the bug

If call loading prop in MultiSelect, typescript shows error, but the component works fine.

Reproducer

https://stackblitz.com/run?file=src%2FApp.tsx

PrimeReact version

10.5.1

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

Call the loading props with its type
@datacampsis datacampsis added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 7, 2024
@melloware melloware added Typescript Issue or pull request is *only* related to TypeScript definition and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 7, 2024
@melloware melloware self-assigned this Mar 7, 2024
@melloware melloware added this to the 10.5.2 milestone Mar 7, 2024
melloware added a commit to melloware/primereact that referenced this issue Mar 7, 2024
@melloware
Fix primefaces#6113: MultiSelect loading and loadingIcon types
643f577
@melloware melloware mentioned this issue Mar 7, 2024
Merged
melloware added a commit to melloware/primereact that referenced this issue Mar 7, 2024
@melloware
Fix primefaces#6113: MultiSelect loading and loadingIcon types
e97105d
@melloware
Copy link
Member

PR submitted.

nitrogenous added a commit that referenced this issue Mar 14, 2024
@nitrogenous
Merge pull request #6114 from melloware/PR6113
cd52101 
Fix #6113: MultiSelect loading and loadingIcon types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
10.5.2
Development

Successfully merging a pull request may close this issue.

Fix #6113: MultiSelect loading and loadingIcon types melloware/primereact
2 participants
@melloware @datacampsis