Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu: No ripple effect #5901

Closed
zawasp opened this issue Feb 5, 2024 · 0 comments · Fixed by #5903
Closed

Menu: No ripple effect #5901

zawasp opened this issue Feb 5, 2024 · 0 comments · Fixed by #5903
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.5.0

Comments

@zawasp
Copy link
Contributor

zawasp commented Feb 5, 2024

Describe the bug

No ripple effect on clicking on Menu and PanelMenu items. It works on other menu types

Reproducer

https://primereact.org/menu/

PrimeReact version

10.4.0

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

all

Steps to reproduce the behavior

Go to https://primereact.org/menu/ and click on menu items in the demos.

Expected behavior

Ripple effect should be active
@zawasp zawasp added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 5, 2024
melloware added a commit to melloware/primereact that referenced this issue Feb 5, 2024
@melloware
Fix primefaces#5901: Menu/PanelMenu ripple effect
c951f0e
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 5, 2024
@melloware melloware added this to the 10.5.0 milestone Feb 5, 2024
@melloware melloware self-assigned this Feb 5, 2024
@melloware melloware mentioned this issue Feb 5, 2024
Merged
melloware added a commit that referenced this issue Feb 5, 2024
@melloware
Fix #5901: Menu/PanelMenu ripple effect (#5903)
78c9f6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.5.0
Development

Successfully merging a pull request may close this issue.

Fix #5901: Menu/PanelMenu ripple effect melloware/primereact
2 participants
@zawasp @melloware