Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

className is not passed to TieredMenu items #5868

Closed
kazamov opened this issue Feb 1, 2024 · 2 comments · Fixed by #5869
Closed

className is not passed to TieredMenu items #5868

kazamov opened this issue Feb 1, 2024 · 2 comments · Fixed by #5869
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.4.0

Comments

@kazamov
Copy link
Contributor

kazamov commented Feb 1, 2024

Describe the bug

When I try to pass a custom className to the TieredMenu component menu item model it is not applied to the menu item element.

Reproducer

https://codesandbox.io/p/live/ad61d04c-20ba-4db1-ad1e-c1d659c5892a

PrimeReact version

10.3.3

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Create a menu model and pass the className property to any model's item.
  2. Pass model to TieredMenu component.
  3. Build and serve application.
  4. Open devtools, open a menu and find an menu item element where you expect a custom class to be passed.

Expected behavior

Custom class name should be passed to the menu item element: e.g. class="p-menuitem custom-class"
@kazamov kazamov added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 1, 2024
melloware added a commit to melloware/primereact that referenced this issue Feb 1, 2024
@melloware
Fix primefaces#5868: TieredMenu respect menuitem className
a20d3c9
@melloware melloware self-assigned this Feb 1, 2024
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 1, 2024
@melloware melloware added this to the 10.4.0 milestone Feb 1, 2024
@melloware
Copy link
Member

Good catch. Fixed for next release.

@melloware melloware mentioned this issue Feb 1, 2024
Merged
melloware added a commit that referenced this issue Feb 1, 2024
@melloware
Fix #5868: TieredMenu respect menuitem className (#5869)
1f613e3
@kazamov kazamov changed the title className is not passes to TieredMenu items className is not passed to TieredMenu items Feb 1, 2024
@kazamov
Copy link
Contributor Author

kazamov commented Feb 1, 2024

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.4.0
Development

Successfully merging a pull request may close this issue.

Fix #5868: TieredMenu respect menuitem className melloware/primereact
2 participants
@kazamov @melloware