Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown: Missing property loading in DropdownProps Interface #5847

Closed
Xizted opened this issue Jan 28, 2024 · 1 comment · Fixed by #5848
Closed

Dropdown: Missing property loading in DropdownProps Interface #5847

Xizted opened this issue Jan 28, 2024 · 1 comment · Fixed by #5848
Assignees
@melloware
Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Milestone
10.4.0

Comments

@Xizted
Copy link

Xizted commented Jan 28, 2024 •
edited
Loading

Describe the bug

The loading property is missing in the interface of the dropdown component
Screenshot 2024-01-28 at 2 11 06 AM

Reproducer

https://stackblitz.com/edit/stackblitz-starters-lhqxaq

PrimeReact version

10.3.3

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Xizted Xizted added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 28, 2024
@melloware melloware added Typescript Issue or pull request is *only* related to TypeScript definition and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 28, 2024
@melloware melloware self-assigned this Jan 28, 2024
@melloware melloware added this to the 10.4.0 milestone Jan 28, 2024
@melloware
Copy link
Member

Yep its missing loading and loadingIcon i will fix now.

melloware added a commit to melloware/primereact that referenced this issue Jan 28, 2024
@melloware
Fix primefaces#5847: Dropdown typescript loading/icon
334dfcf
@melloware melloware mentioned this issue Jan 28, 2024
Merged
melloware added a commit to melloware/primereact that referenced this issue Jan 28, 2024
@melloware
Fix primefaces#5847: Dropdown typescript loading/icon
bf4f131
melloware added a commit that referenced this issue Jan 28, 2024
@melloware
Fix #5847: Dropdown typescript loading/icon (#5848)
65fe174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
10.4.0
Development

Successfully merging a pull request may close this issue.

Fix #5847: Dropdown typescript loading/icon melloware/primereact
2 participants
@melloware @Xizted