Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tailwind: Card subtitle vs subTitle and similar issues #5461

Closed
Dalorzo opened this issue Nov 30, 2023 · 1 comment · Fixed by #5470 or #5484
Closed

Tailwind: Card subtitle vs subTitle and similar issues #5461

Dalorzo opened this issue Nov 30, 2023 · 1 comment · Fixed by #5470 or #5484
Assignees
@melloware
Labels
Component: Tailwind Tailwind specific issue
Milestone
10.3.0

Comments

@Dalorzo
Copy link
Contributor

Dalorzo commented Nov 30, 2023 •
edited
Loading

Tailwind: Card subtitle vs subTitle, the property in passthrough is camelCase

primereact/components/lib/passthrough/tailwind/index.js

Line 172 in ad61ccf

subtitle: {

dropdownbutton vs dropdownButton

primereact/components/lib/passthrough/tailwind/index.js

Line 1158 in ad61ccf

dropdownbutton: ({ props }) => ({

dropdownbutton: ({ props }) => ({

optiongroupicon vs optionGroupIcon

primereact/components/lib/passthrough/tailwind/index.js

Line 857 in ad61ccf

optiongroupicon: 'ml-auto',

uploadbutton vs uploadButton, cancelbutton vs cancelButton , uploadicon vs uploadIcon

primereact/components/lib/passthrough/tailwind/index.js

Line 519 in ad61ccf

uploadbutton: {

meterlabel VS meterLabel showIcon, headerIcon

primereact/components/lib/passthrough/tailwind/index.js

Line 980 in ad61ccf

meterlabel: ({ state, props }) => ({

rating all camelCase properties

primereact/components/lib/passthrough/tailwind/index.js

Line 863 in ad61ccf

rating: {

focused does not exists, it seems it is active now.

primereact/components/lib/passthrough/tailwind/index.js

Line 889 in ad61ccf

'outline-none outline-offset-0 shadow-[0_0_0_0.2rem_rgba(191,219,254,1)] dark:shadow-[0_0_0_0.2rem_rgba(147,197,253,0.5)]': context.focused

SplitButton camelCase properties menuButton, menuList

primereact/components/lib/passthrough/tailwind/index.js

Line 753 in ad61ccf

menulist: 'm-0 p-0 border-none outline-none no-underline list-none',

@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 30, 2023
@Dalorzo Dalorzo changed the title Tailwind: Card subtitle vs subTitle Tailwind: Card subtitle vs subTitle and similar issues Nov 30, 2023
@melloware melloware added Component: Tailwind Tailwind specific issue and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 30, 2023
@melloware melloware self-assigned this Nov 30, 2023
@melloware melloware added this to the 10.2.2 milestone Nov 30, 2023
melloware added a commit to melloware/primereact that referenced this issue Nov 30, 2023
@melloware
Fix primefaces#5461: Passthrough case insensitve props
63ac127
@melloware melloware mentioned this issue Nov 30, 2023
Merged
@melloware
Copy link
Member

I think the passthrough values should be case insensitive so dropdownButton or dropdownbutton should not matter.

melloware added a commit to melloware/primereact that referenced this issue Nov 30, 2023
@melloware
Fix primefaces#5461: Passthrough case insensitve props
41ab92a
melloware added a commit to melloware/primereact that referenced this issue Nov 30, 2023
@melloware
Fix primefaces#5461: Passthrough case insensitve props
d288169
melloware added a commit to melloware/primereact that referenced this issue Nov 30, 2023
@melloware
Fix primefaces#5461: Passthrough case insensitive props
3e38203
melloware added a commit that referenced this issue Nov 30, 2023
@melloware
Fix #5461: Passthrough case insensitive props (#5470)
d0b3eae
melloware added a commit to melloware/primereact that referenced this issue Dec 1, 2023
@melloware
Fix primefaces#5461: Passthrough TS and casing issues
e9debc1
@melloware melloware mentioned this issue Dec 1, 2023
Merged
melloware added a commit to melloware/primereact that referenced this issue Dec 1, 2023
@melloware
Fix primefaces#5461: Passthrough TS and casing issues
f99673d
melloware added a commit that referenced this issue Dec 1, 2023
@melloware
Fix #5461: Passthrough TS and casing issues (#5484)
bc405bd
melloware added a commit to melloware/primereact that referenced this issue Jan 9, 2024
@melloware
Fix primefaces#5461: Passthrough case insensitve props
710c5f3
melloware added a commit to melloware/primereact that referenced this issue Jan 9, 2024
@melloware
Fix primefaces#5461: Passthrough TS and casing issues
4b5b7d0
melloware added a commit that referenced this issue Jan 9, 2024
@melloware
Port fixes4 (#5712)
017ad34 
* Fix #5444/#5443: Tailwind fixes

* Fix #5447: TreeSelect don't close panel on unselect

* Fix #5445: Tabview passthrough fixes

* Fix #5452: Datatable onRowEditChange typescript def

* Fix #5461: Passthrough case insensitve props

* Fix #5465: Sidebar passthrough fix

* Fix #5466: Slider remove handlers

* Fix #5464: Tailwind fixes

* Fix #5477: ComponentBase fkey refactor

* Fix #5461: Passthrough TS and casing issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Tailwind Tailwind specific issue
Projects
None yet
Milestone
10.3.0
2 participants
@melloware @Dalorzo