Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable: Moving selection up with keyboard not working #5347

Closed
Frdnspnzr opened this issue Nov 20, 2023 · 1 comment · Fixed by #5348
Closed

DataTable: Moving selection up with keyboard not working #5347

Frdnspnzr opened this issue Nov 20, 2023 · 1 comment · Fixed by #5348
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.1.1

Comments

@Frdnspnzr
Copy link

Describe the bug

Changing the selected row using the up arrow on the keyboard throws an unhandled exception "TypeError: can't assign to property "tabIndex" on true: not an object". Moving the selection down with the down arrow key works as expected.

Reproducer

https://codesandbox.io/s/xvcfxx

PrimeReact version

10.0.9

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Frdnspnzr Frdnspnzr added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 20, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 20, 2023
@melloware melloware self-assigned this Nov 20, 2023
@melloware melloware added this to the 10.2.0 milestone Nov 20, 2023
melloware added a commit to melloware/primereact that referenced this issue Nov 20, 2023
@melloware
Fix primefaces#5347: Selection previous row with up arrow NPE
b1d6913
@melloware melloware mentioned this issue Nov 20, 2023
Merged
@melloware
Copy link
Member

Thanks for the report!

melloware added a commit that referenced this issue Nov 20, 2023
@melloware
Fix #5347: Selection previous row with up arrow NPE (#5348)
8d96f39
@mertsincan mertsincan modified the milestones: 10.2.0, 10.1.1 Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.1.1
Development

Successfully merging a pull request may close this issue.

Fix #5347: Selection previous row with up arrow NPE melloware/primereact
3 participants
@Frdnspnzr @melloware @mertsincan