Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeSelect: In unstyled mode, the selected and checked style not work #5254

Closed
kl-nevermore opened this issue Nov 7, 2023 · 1 comment · Fixed by #5257
Closed

TreeSelect: In unstyled mode, the selected and checked style not work #5254

kl-nevermore opened this issue Nov 7, 2023 · 1 comment · Fixed by #5257
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.1.0

Comments

@kl-nevermore
Copy link
Contributor

kl-nevermore commented Nov 7, 2023 •
edited
Loading

Describe the bug

20231107144318_rec_

When I use pt,context.selected and context.checked always undefined

https://github.com/primefaces/primereact/blob/master/components/lib/tree/UITreeNode.js#L21C42-L21C42
maybe missed selected and checked
https://github.com/primefaces/primereact/blob/master/components/lib/tree/Tree.js#L340

Reproducer

https://codesandbox.io/p/sandbox/primereact-demo-forked-cpdt3v?file=%2Fsrc%2FApp.js%3A25%2C33

PrimeReact version

10.0.9

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

Chrome 118

Steps to reproduce the behavior

No response

Expected behavior

No response
@kl-nevermore kl-nevermore added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 7, 2023
@kl-nevermore
Copy link
Contributor Author

it's work in primevue

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 7, 2023
@melloware melloware self-assigned this Nov 7, 2023
@melloware melloware added this to the 10.0.10 milestone Nov 7, 2023
melloware added a commit to melloware/primereact that referenced this issue Nov 7, 2023
@melloware
Fix primefaces#5254: TreeNode PT incorrect props
727655e
@melloware melloware mentioned this issue Nov 7, 2023
Merged
melloware added a commit that referenced this issue Nov 7, 2023
@melloware
Fix #5254: TreeNode PT incorrect props (#5257)
c3ef28f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.1.0
Development

Successfully merging a pull request may close this issue.

Fix #5254: TreeNode PT incorrect props melloware/primereact
2 participants
@melloware @kl-nevermore