Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable: When using InputTextarea as editor, pressing Ctrl + Enter or Shift + Enter results in a submission #5192

Closed
dangnhdev opened this issue Oct 30, 2023 · 0 comments · Fixed by #5195
Closed

DataTable: When using InputTextarea as editor, pressing Ctrl + Enter or Shift + Enter results in a submission #5192

dangnhdev opened this issue Oct 30, 2023 · 0 comments · Fixed by #5195
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.0.8

Comments

@dangnhdev
Copy link
Contributor

dangnhdev commented Oct 30, 2023 •
edited
Loading

Describe the bug

When using InputTextarea Editor, pressing Ctrl + Enter or Shift + Enter results in a submission rather than the expected new line entry.

Reproducer

https://stackblitz.com/edit/react-yqyeub?file=src%2FApp.js

PrimeReact version

10.0.7

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

In the InputTextarea Editor, the action of pressing either Ctrl + Enter or Shift + Enter should facilitate the addition of a new line.
@dangnhdev dangnhdev added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 30, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 30, 2023
@melloware melloware self-assigned this Oct 30, 2023
@melloware melloware added this to the 10.0.8 milestone Oct 30, 2023
melloware added a commit to melloware/primereact that referenced this issue Oct 30, 2023
@melloware
Fix primefaces#5192: Allow CTRL/SHIFT + ENTER for TextArea
ef9ce5f
@melloware melloware mentioned this issue Oct 30, 2023
Merged
melloware added a commit that referenced this issue Oct 30, 2023
@melloware
Fix #5192: Allow CTRL/SHIFT + ENTER for TextArea (#5195)
938dd67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.0.8
Development

Successfully merging a pull request may close this issue.

Fix #5192: Allow CTRL/SHIFT + ENTER for TextArea melloware/primereact
2 participants
@melloware @dangnhdev