Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are two CSS variables that represent the secondary text color at the same time #5060

Closed
Traveller23 opened this issue Oct 9, 2023 · 0 comments · Fixed by #5066
Closed

There are two CSS variables that represent the secondary text color at the same time #5060

Traveller23 opened this issue Oct 9, 2023 · 0 comments · Fixed by #5066
Assignees
@melloware
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone
10.0.3

Comments

@Traveller23
Copy link

Describe the bug

--text-color-secondary occurs 60 times throughout the project
--text-secondary-color occurs 9 times throughout the project

I found this out because I saw the name --text-secondary-color on https://primereact.org/colors/, but when I used it in my project I found that it didn't override the corresponding variable in /themes/mdc-dark-indigo/theme.css. I realized that it's called --text-color-secondary here.

I found a similar issue at the same time, but it seems that not all naming inconsistencies were resolved at that time.

Reproducer

No response

PrimeReact version

10.0.2

React version

18.x

Language

TypeScript

Build / Runtime

Next.js

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Traveller23 Traveller23 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 9, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 9, 2023
@melloware melloware self-assigned this Oct 9, 2023
@melloware melloware added this to the 10.0.3 milestone Oct 9, 2023
melloware added a commit to melloware/primereact that referenced this issue Oct 9, 2023
@melloware
Fix primefaces#5060: --text-color-secondary
95ec069
@melloware melloware mentioned this issue Oct 9, 2023
Merged
melloware added a commit that referenced this issue Oct 9, 2023
@melloware
Fix #5060: --text-color-secondary (#5066)
8ba7b30
@melloware melloware added Component: Documentation Issue or pull request is related to Documentation and removed Type: Bug Issue contains a defect related to a specific component. labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Milestone
10.0.3
Development

Successfully merging a pull request may close this issue.

Fix #5060: --text-color-secondary melloware/primereact
2 participants
@melloware @Traveller23