InputNumber: Doesn't allow minus sign in currency mode

[VasiliPodoplielov]

Describe the bug

Hello.
I faced problem in InputNumber when I use this component like this:
<InputNumber mode="currency" currency="USD" />
It uses prefix in input under the hood. So the problem is related not only to the currency mode but also when I use any prefix.

When I populate some value to the field and after that want to make this value negative by adding - minus sign - it happens nothing. After some investigation I found out that problem might be related to this part of code:

because selectionStart=1, prefix has a position 0 and minus sign should be on -1 position.

Another problem, when I have a negative value with prefix inside an input, e.g. -$123 I cant remove value from input by pressing backspace. I need highlight the whole value and after that press backspace or delete button.

Reproducer

https://codesandbox.io/s/primereact-demo-forked-pj7tdw?file=/src/App.js

PrimeReact version

9.6.2

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

1. Type some number
2. Set cursor at the start of number(before the number)
3. Try press minus sign

Expected behavior

It should be possible to add minus sign when cursor is at the start(before the number).
It shuold be possible to remove negative number by pressing backspace.

[VasiliPodoplielov]

Hi. Does the solution fix the problem when I can't remove negative value from the field?
I mean there is -$1.00 in the field and the cursor is between 1 and .
When changes will be available to use?
Thanks.

[melloware]

@akshayantony55 can you test the above scenario?

[akshayaqburst]

@melloware Where can I test the recently merged changes?

[melloware]

just do a git pull from master and run npm run dev it runs the full showcase with the current code.

[VasiliPodoplielov]

@melloware
I cloned master, run npm install, run npm run dev, open http://localhost:3000/inputnumber/ and tried type - before an existed number.

[akshayaqburst]

Seems there is a typo with the suggested code. I will create a new PR soon.

[VasiliPodoplielov]

I added - and it is between dollar sign and numbers and after blur value in field formats and looks as expected.
Another problem - I can add - in any place, but after that the field is cleaned.
Case that I described in previos message - is not fixed.

[akshayantony55]

@VasiliPodoplielov If the value is invalid, it cleans the input field. Thats an expected behaviour.
I will work on supporting removing - sign + the typo introduced with the previous pull request.

[VasiliPodoplielov]

@akshayaqburst
Hm...I thought that input should be blocked from not allowed symbols.
Thanks.

[akshayaqburst]

@melloware I have fixed the typo issue with the previous PR and also added the ability to remove - sign as requested by @VasiliPodoplielov.
Thanks,

[VasiliPodoplielov]

Sorry guys, is it a new feature that now it is possible to fill in the InputNumber field by numbers and letters?
I saw previous comments that field value will be cleared. I just compare with current behaviour in the last version.

[melloware]

it should not be. What was the last version that worked. To me it should NOT take characters.

[melloware]

@VasiliPodoplielov can you update my reproducer to show the issue? https://stackblitz.com/edit/react-fv1wob?file=src%2FApp.js

I can't reproduce so can you show me your exact settings that make it happen.

[melloware]

OK there are bigger issues here I need to investigate.

[melloware]

OK I think I got all the issues. only 1 minus sign. BACKSPACE works to remove the minus sign. It goes in the correct place etc.

[VasiliPodoplielov]

@melloware looks great.
Thanks everyone who took part in fixing process.

Sorry, when these changes will be available to use?

[melloware]

Thanks for testing! I think 10.0.0 is due out next week