Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BreadCrumb: label home prop doesn't work #4504

Closed
likhuta91 opened this issue Jun 13, 2023 · 1 comment · Fixed by #4506
Closed

BreadCrumb: label home prop doesn't work #4504

likhuta91 opened this issue Jun 13, 2023 · 1 comment · Fixed by #4506
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
9.6.0

Comments

@likhuta91
Copy link

Describe the bug

If I pass label to home prop in Breadcrumbs component like this :
<BreadCrumb home={{ label: 'some label', }} />
label will be ignored https://github.com/primefaces/primereact/blob/master/components/lib/breadcrumb/BreadCrumb.js#L43.
Label works for model prop but not for home but they use the same type MenuItem

Reproducer

No response

PrimeReact version

9.5.0

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

home and model accept the same type (MenuItem) so they should work the same
@likhuta91 likhuta91 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 13, 2023
@melloware melloware changed the title Component: label from Breadcrumb home prop doesn't work BreadCrumb: label home prop doesn't work Jun 13, 2023
melloware added a commit to melloware/primereact that referenced this issue Jun 13, 2023
@melloware
Fix primefaces#4504: Breadcrumb allow label in home
98448d3
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 13, 2023
@melloware melloware self-assigned this Jun 13, 2023
@melloware melloware added this to the 9.6.0 milestone Jun 13, 2023
@melloware
Copy link
Member

You are correct thanks for the report!

@melloware melloware mentioned this issue Jun 13, 2023
Merged
melloware added a commit to melloware/primereact that referenced this issue Jun 13, 2023
@melloware
Fix primefaces#4504: Breadcrumb allow label in home
78be568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
9.6.0
Development

Successfully merging a pull request may close this issue.

Fix #4504: Breadcrumb allow label in home melloware/primereact
2 participants
@melloware @likhuta91