Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datatable: Setting rowEditorInitIcon has no effect. #4430

Closed
ecstrema opened this issue May 21, 2023 · 5 comments · Fixed by #4433 or #5341
Closed

Datatable: Setting rowEditorInitIcon has no effect. #4430

ecstrema opened this issue May 21, 2023 · 5 comments · Fixed by #4433 or #5341
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.1.0

Comments

@ecstrema
Copy link
Contributor

ecstrema commented May 21, 2023 •
edited
Loading

Describe the bug

Setting rowEditorInitIcon on datatable seems like it does nothing. Even, if I step into the debugger, it shows the the prop is not accessible to the column editor.

Reproducer

https://codesandbox.io/s/primereact-demo-forked-wim1ts

PrimeReact version

9.4.0

React version

17.x

Browser(s)

Chrome

Steps to reproduce the behavior

Open the reproducer: the icon is customized, it should show some text instead.
@ecstrema ecstrema added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 21, 2023
@melloware melloware changed the title Component: Datatable: Setting rowEditorInitIcon has no effect. Datatable: Setting rowEditorInitIcon has no effect. May 22, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 22, 2023
melloware added a commit to melloware/primereact that referenced this issue May 22, 2023
@melloware
Fix primefaces#4430: Row editor icon overrides
7d5b08e
@melloware melloware mentioned this issue May 22, 2023
Merged
@melloware melloware self-assigned this May 22, 2023
@melloware melloware added this to the 9.5.0 milestone May 22, 2023
melloware added a commit that referenced this issue May 22, 2023
@melloware
Fix #4430: Row editor icon overrides (#4433)
794cc6e
@MBelniak
Copy link
Contributor

It's not working for me. Can anyone show some code snippet of a working example?

@melloware melloware reopened this Nov 17, 2023
@melloware melloware modified the milestones: 9.5.0, 10.0.10 Nov 17, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 17, 2023
@melloware
Copy link
Member

You are right it was only fixed for frozen tables not regular. Fixing now.

@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 17, 2023
melloware added a commit to melloware/primereact that referenced this issue Nov 17, 2023
@melloware
Fix primefaces#4430: RowEdit icon customization fix
2857396
@melloware melloware mentioned this issue Nov 17, 2023
Merged
melloware added a commit that referenced this issue Nov 17, 2023
@melloware
Fix #4430: RowEdit icon customization fix (#5341)
262b790
@melloware
Copy link
Member

Fixed for 10.0.10

@MBelniak
Copy link
Contributor

Damn, that was fast 😅 Many thanks

@melloware
Copy link
Member

@MBelniak looks like I only fixed "half" of it last time 😄 Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.1.0
3 participants
@melloware @MBelniak @ecstrema