Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiSelect clear icon not aligned correctly #4427

Closed
manuelpoelzl opened this issue May 20, 2023 · 1 comment · Fixed by #4429
Closed

MultiSelect clear icon not aligned correctly #4427

manuelpoelzl opened this issue May 20, 2023 · 1 comment · Fixed by #4429
Assignees
@ulasturann
Labels
Component: Theme Issue or pull request is related to Theme Type: Bug Issue contains a defect related to a specific component.
Milestone
9.5.0

Comments

@manuelpoelzl
Copy link

Describe the bug

The clear icon of the multiselect component used to look like this:
Screenshot_6

But in 9.4.0 it is not aligned correctly anymore:
Screenshot_7

Reproducer

https://codesandbox.io/s/primereact-test-forked-j9mtn0?file=/src/index.js

PrimeReact version

9.4.0

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

Microsoft Edge Version 113.0.1774.42

Steps to reproduce the behavior

  1. Create a multiselect component with the showClear property set to true.
  2. Select one or more items from the multiselect
  3. Look at the alignment of the clear icon

Expected behavior

The clear icon should be aligned properly.
@manuelpoelzl manuelpoelzl added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 20, 2023
melloware added a commit to melloware/primereact that referenced this issue May 21, 2023
@melloware
Fix primefaces#4427: Multiselect clear icon
4d7bec8
@melloware melloware self-assigned this May 21, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. Component: Theme Issue or pull request is related to Theme and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 21, 2023
@melloware melloware added this to the 9.5.0 milestone May 21, 2023
@melloware melloware mentioned this issue May 21, 2023
Merged
@melloware
Copy link
Member

melloware commented May 21, 2023 •
edited
Loading

Have to make a code fix and a theme fix.

Theme Issue: primefaces/primereact-sass-theme#14

@melloware melloware mentioned this issue May 21, 2023
Closed
melloware added a commit that referenced this issue May 21, 2023
@melloware
Fix #4427: Multiselect clear icon (#4429)
e159872
@melloware melloware reopened this May 21, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 21, 2023
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 22, 2023
@mertsincan mertsincan modified the milestones: 9.5.0, 9.6.0 May 23, 2023
@ulasturann ulasturann modified the milestones: 9.6.0, 9.5.0 May 23, 2023
@ulasturann ulasturann assigned ulasturann and unassigned melloware May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulasturann ulasturann

Labels
Component: Theme Issue or pull request is related to Theme Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
9.5.0
Development

Successfully merging a pull request may close this issue.

Fix #4427: Multiselect clear icon melloware/primereact
4 participants
@melloware @mertsincan @manuelpoelzl @ulasturann