Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events: Forward preventDefault, stopPropagation from original event #4375

Closed
melloware opened this issue May 10, 2023 · 0 comments · Fixed by #4376
Closed

Events: Forward preventDefault, stopPropagation from original event #4375

melloware opened this issue May 10, 2023 · 0 comments · Fixed by #4376
Assignees
@melloware
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
9.4.0

Comments

@melloware
Copy link
Member

In PrimeReact custom event creation that hands back the originalEvent the preventDefault and stopPropagation do nothing. To me this is confusing for users that call event.preventDefault() that does nothing and they need to do event.originalEvent.preventDefault().
melloware added a commit to melloware/primereact that referenced this issue May 10, 2023
@melloware
Fix primefaces#4375: Events forward stopPropagation and preventDefault
182f962
@melloware melloware mentioned this issue May 10, 2023
Merged
@melloware melloware self-assigned this May 10, 2023
@melloware melloware added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label May 10, 2023
@melloware melloware added this to the 9.4.0 milestone May 10, 2023
melloware added a commit to melloware/primereact that referenced this issue May 10, 2023
@melloware
Fix primefaces#4375: Events forward stopPropagation and preventDefault
a0542f2
melloware added a commit that referenced this issue May 10, 2023
@melloware
Fix #4375: Events forward stopPropagation and preventDefault (#4376)
58168a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
9.4.0
Development

Successfully merging a pull request may close this issue.

Fix #4375: Events forward stopPropagation and preventDefault melloware/primereact
1 participant
@melloware