Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpeedDial: buttonTemplate not working #4305

Closed
ipahe1 opened this issue Apr 28, 2023 · 1 comment · Fixed by #4307
Closed

SpeedDial: buttonTemplate not working #4305

ipahe1 opened this issue Apr 28, 2023 · 1 comment · Fixed by #4307
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
9.4.0

Comments

@ipahe1
Copy link

ipahe1 commented Apr 28, 2023

Describe the bug

  • The newest Prime React Version (9.x) is including on the documentation the prop buttonTemplate even worse the component is no acting as should be.
  • Checking the component's code and comparing with previous version (8.x) I nottice that the code related to buttonTemplate has been deleted.

Reproducer

No response

PrimeReact version

9.3.1

React version

17.x

Language

ES6

Build / Runtime

Create React App (CRA)

Browser(s)

All

Steps to reproduce the behavior

  1. Add prop buttonTemplate to SpeedDial component
  2. Check the behavior on the browser

Expected behavior

The SpeedDial button must consider buttonTemplate if exist as prop.
@ipahe1 ipahe1 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 28, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 28, 2023
@melloware
Copy link
Member

Looks like it was removed with: #4220 looking into it

@melloware melloware changed the title Speed Dial Component Speed Dial: buttonTemplate not working Apr 28, 2023
@melloware melloware self-assigned this Apr 28, 2023
@melloware melloware added this to the 9.4.0 milestone Apr 28, 2023
melloware added a commit to melloware/primereact that referenced this issue Apr 28, 2023
@melloware
Fix primefaces#4305: SpeedDialog buttonTemplate restored
14ea6d2
@melloware melloware mentioned this issue Apr 28, 2023
Merged
melloware added a commit to melloware/primereact that referenced this issue May 2, 2023
@melloware
Fix primefaces#4305: SpeedDialog buttonTemplate restored
e0ed67b
@melloware melloware changed the title Speed Dial: buttonTemplate not working SpeedDial: buttonTemplate not working May 3, 2023
melloware added a commit to melloware/primereact that referenced this issue May 3, 2023
@melloware
Fix primefaces#4305: SpeedDialog buttonTemplate restored
8e579c5
melloware added a commit that referenced this issue May 3, 2023
@melloware
Fix #4305: SpeedDialog buttonTemplate restored (#4307)
1304fd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
9.4.0
Development

Successfully merging a pull request may close this issue.

Fix #4305: SpeedDial buttonTemplate restored melloware/primereact
2 participants
@melloware @ipahe1