Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: paginator with alwaysShowPaginator: false is displayed for empty table #4254

Closed
andreev-artem opened this issue Apr 18, 2023 · 3 comments · Fixed by #4255
Closed
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@andreev-artem
Copy link

Describe the bug

https://github.com/primefaces/primereact/blob/master/components/lib/paginator/Paginator.js#L194

It will be hidden only if pageCount === 1

Reproducer

No response

PrimeReact version

9.2.2

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@andreev-artem andreev-artem added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 18, 2023
@melloware
Copy link
Member

Should be pageCount <= 1 right? So if pageCount is 0 or -1 it would also not display?

@andreev-artem
Copy link
Author

Yep, I think it should work in that way.

melloware added a commit to melloware/primereact that referenced this issue Apr 18, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 18, 2023
@melloware melloware self-assigned this Apr 18, 2023
@melloware melloware added this to the 9.3.1 milestone Apr 18, 2023
@melloware
Copy link
Member

PR submitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants