Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree: Missing property dropNode in type signature of TreeDragDropEvent #4179

Closed
Laeri opened this issue Mar 24, 2023 · 3 comments · Fixed by #4182
Closed

Tree: Missing property dropNode in type signature of TreeDragDropEvent #4179

Laeri opened this issue Mar 24, 2023 · 3 comments · Fixed by #4182
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component. Typescript Issue or pull request is *only* related to TypeScript definition
Milestone
9.2.2

Comments

@Laeri
Copy link

Laeri commented Mar 24, 2023 •
edited
Loading

Describe the bug

The https://primereact.org/tree/#api.Tree.TreeDragDropEvent has a wrong type signature as I believe. The dropNode is missing from the TreeDragDropEvent. However, in Tree.js that property is still returned in the event.

As far as I have seen commit: 70bb1e5 introduced this error.

Reproducer

No response

PrimeReact version

9.2.1

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Laeri Laeri added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 24, 2023
@Laeri Laeri changed the title Tree: Tree: Missing property dropNode in type signature of TreeDragDropEvent Mar 24, 2023
melloware added a commit to melloware/primereact that referenced this issue Mar 24, 2023
@melloware
Fix primefaces#4179: Tree drag drop typescript update
df53eb2
@melloware melloware added Typescript Issue or pull request is *only* related to TypeScript definition and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 24, 2023
@melloware melloware self-assigned this Mar 24, 2023
@melloware melloware added this to the 9.2.2 milestone Mar 24, 2023
@melloware melloware mentioned this issue Mar 24, 2023
Merged
@melloware
Copy link
Member

Thanks for the report! Please review my PR.

@Laeri
Copy link
Author

Laeri commented Mar 25, 2023

Looks good, thank you for fixing it.

@Laeri Laeri closed this as completed Mar 25, 2023
@melloware melloware reopened this Mar 25, 2023
@melloware
Copy link
Member

Reopened it didn't get merged yet.

@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 25, 2023
@mertsincan mertsincan added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 27, 2023
mertsincan pushed a commit that referenced this issue Mar 27, 2023
@melloware
Fix #4179: Tree drag drop typescript update (#4182)
73840ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component. Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
9.2.2
Development

Successfully merging a pull request may close this issue.

Fix #4179: Tree drag drop typescript update melloware/primereact
3 participants
@melloware @mertsincan @Laeri