Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types(severity): Inconsistency #4169

Closed
EmirBoyaci opened this issue Mar 21, 2023 · 6 comments · Fixed by #5985
Closed

Types(severity): Inconsistency #4169

EmirBoyaci opened this issue Mar 21, 2023 · 6 comments · Fixed by #5985
Assignees
@cagataycivici @melloware
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Typescript Issue or pull request is *only* related to TypeScript definition
Milestone
10.6.4

Comments

@EmirBoyaci
Copy link
Contributor

Describe the feature you would like to see added

Hi,

Currently we are having severity in 7 different places. Instead of having severity prop's possible values in 7 different places, can we make it in global and import from global types file? I am asking this because, as you can see below in some places we are defining warn, in some places we are defining warning. IMO it is inconsistent and it is better to have unified version of severities in some place. If you wish we can also Omit not necessary possible values while referring global severity type. WDYT?

Screenshot 2023-03-21 at 14 25 57
Screenshot 2023-03-21 at 14 26 08
Screenshot 2023-03-21 at 14 28 24

Is your feature request related to a problem?

No response

Describe the solution you'd like

No response

Describe alternatives you have considered

No response

Additional context

No response
@EmirBoyaci EmirBoyaci added Status: Discussion Issue or pull request needs to be discussed by Core Team Type: New Feature Issue contains a new feature or new component request labels Mar 21, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 21, 2023
@EmirBoyaci
Copy link
Contributor Author

It is also possible to agree one of warn or warning and just change this instead of making severity type global. But, FMPOV we should make it consistent somehow.

@EmirBoyaci EmirBoyaci changed the title Types(severity): Consistency Types(severity): Inconsistency Mar 21, 2023
@melloware
Copy link
Member

I suggested the same thing with a PR: #4040

@melloware melloware added Typescript Issue or pull request is *only* related to TypeScript definition and removed Type: New Feature Issue contains a new feature or new component request Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 21, 2023
@EmirBoyaci
Copy link
Contributor Author

I suggested the same thing with a PR: #4040

That's what I was offering. I'm happy to be on the same page with you. Thanks!

@melloware melloware mentioned this issue Nov 26, 2023
Open
@melloware
Copy link
Member

Similar to #5404

@cagataycivici
Copy link
Member

@mertsincan We should have a look at this case for next release I think.

@mertsincan mertsincan added this to the 10.4.0 milestone Jan 11, 2024
melloware added a commit to melloware/primereact that referenced this issue Jan 13, 2024
@melloware
Fix primefaces#4169: Severity consistency
5e54cc1
melloware added a commit to melloware/primereact that referenced this issue Jan 13, 2024
@melloware
Fix primefaces#4169: Severity consistency
e4a05e9
@melloware melloware mentioned this issue Jan 13, 2024
Closed
5 tasks
@melloware
Copy link
Member

melloware commented Jan 13, 2024 •
edited
Loading

I have made everything consistent and updated the TS defs and Tailwind styles now just need to update the theme CSS.

@melloware melloware assigned melloware and unassigned mertsincan Jan 13, 2024
@melloware melloware removed the Status: Discussion Issue or pull request needs to be discussed by Core Team label Jan 13, 2024
@melloware melloware mentioned this issue Jan 13, 2024
Closed
@mertsincan mertsincan modified the milestones: 10.4.0, 11.0.0 Jan 17, 2024
@mertsincan mertsincan added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jan 17, 2024
melloware added a commit to melloware/primereact that referenced this issue Jan 25, 2024
@melloware
Fix primefaces#4169: Severity consistency
1bb5df0
@melloware melloware mentioned this issue Feb 16, 2024
Merged
@melloware melloware modified the milestones: 11.0.0, 10.6.4 May 3, 2024
@LeandroMarcondes LeandroMarcondes mentioned this issue Jul 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

@melloware melloware

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
10.6.4
4 participants
@cagataycivici @melloware @mertsincan @EmirBoyaci