Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts: Add Accessibility #3982

Closed
melloware opened this issue Jan 25, 2023 · 3 comments · Fixed by #3983
Closed

Charts: Add Accessibility #3982

melloware opened this issue Jan 25, 2023 · 3 comments · Fixed by #3983
Assignees
@melloware
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Milestone
9.4.0

Comments

@melloware
Copy link
Member

melloware commented Jan 25, 2023 •
edited
Loading

All the charts generated have no option to add a "aria-label".
Without any of this information screen readers will simply not acknowledge the presence of the chart in the page nor describe it function to the user.

For reference:
@melloware melloware self-assigned this Jan 25, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 25, 2023
@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 25, 2023
@melloware melloware added this to the 8.7.4 milestone Jan 25, 2023
@mertsincan mertsincan modified the milestones: 8.7.4, 10.0.0 Jan 26, 2023
@Luisa-Cavalheiro
Copy link

Hi there,
I found a similar situation with the form component autocomplete, where we can't add an aria-label to inform screen readers. Is there a recomendation or a solution for this kind of issue?

Thanks in advance.

@melloware melloware modified the milestones: 10.0.0, 9.4.0 Apr 27, 2023
@melloware melloware mentioned this issue Apr 27, 2023
Merged
@melloware
Copy link
Member Author

@Luisa-Cavalheiro the AutoComplete accessibility with be updated in 10.0

melloware added a commit that referenced this issue Apr 27, 2023
@melloware
Fix #3982: Charts add accessibility to canvas (#3983)
a716363 
* Fix #3892: Charts add accessibility to canvas

* Fix #3892: Charts add accessibility to canvas
@Luisa-Cavalheiro
Copy link

Luisa-Cavalheiro commented Apr 27, 2023 •
edited
Loading

Great!
But I'm striggling to understand how aria works with components from libs. Could you help me with that?

@kyybo kyybo mentioned this issue Sep 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Projects
None yet
Milestone
9.4.0
Development

Successfully merging a pull request may close this issue.

Fix #3982: Charts add accessibility to canvas melloware/primereact
3 participants
@melloware @mertsincan @Luisa-Cavalheiro