Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar min date does not work after [email protected] #379

Closed
abuSayedMohammad opened this issue Apr 11, 2018 · 4 comments
Closed

Calendar min date does not work after [email protected] #379

abuSayedMohammad opened this issue Apr 11, 2018 · 4 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@abuSayedMohammad
Copy link

I have two calendar. Ideally, if I select 11/04/18 in my first calendar, all the dates before 11/04/18 should be disabled in 2nd calendar(using minDate and maxDate property).

In primereact latest version(1.5.0), it does not work for first time select, but work every time after that. Corresponding plunk https://plnkr.co/edit/n4YIoArh2oWTIfFN1YXO?p=preview

The same code work in [email protected]. correspoding plunk https://plnkr.co/edit/J3Yz1S3hfGpFBnMzhxaV?p=preview

@jljox
Copy link
Contributor

jljox commented May 3, 2018

This seems to be a regression as the same issue was fixed with #119.
Do you have a unit test for #119 so that I can have a go at creating a pull request?

jljox added a commit to jljox/primereact that referenced this issue May 3, 2018
@jljox jljox mentioned this issue May 3, 2018
@abuSayedMohammad
Copy link
Author

Yes.. this is a regression. I have not got any unit test. If you find the issue is fixed, then better go with pull request. :)

@jljox
Copy link
Contributor

jljox commented May 4, 2018

Yep I've created a pull request. #396

mertsincan added a commit that referenced this issue May 9, 2018
@mertsincan mertsincan self-assigned this May 9, 2018
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label May 9, 2018
@mertsincan mertsincan added this to the 1.6.0 milestone May 9, 2018
@mertsincan
Copy link
Member

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

3 participants